1
0
forked from Cutlery/immich
immich-quadlet/server/apps/immich/test/user.e2e-spec.ts
Jaime Baez 20c5578470
Make user business logic reusable (#1114)
- Refactor user business logic from `user.service` into `user.domain`
  Make user business logic reusable by using `user.domain` from other services than `user.service`

- Add `jest-when` lib to make testing easier and use it in `userService`
  Using when helps from coupling tests to order of mock implementations execution

- Move all user business logic from user-repository to user.service

- Fix user.service tests not awaiting promises leaking state between tests

- Presentation logic for `getUserProfileImage` moved from UserService to UserController

- Fix `user.e2e` test logic. Pending fixing the configuration of the test itself
2022-12-23 21:08:50 +01:00

129 lines
4.1 KiB
TypeScript

import { Test, TestingModule } from '@nestjs/testing';
import { INestApplication } from '@nestjs/common';
import { TypeOrmModule } from '@nestjs/typeorm';
import request from 'supertest';
import { clearDb, authCustom } from './test-utils';
import { databaseConfig } from '@app/database/config/database.config';
import { UserModule } from '../src/api-v1/user/user.module';
import { ImmichJwtModule } from '../src/modules/immich-jwt/immich-jwt.module';
import { UserService } from '../src/api-v1/user/user.service';
import { CreateAdminDto, CreateUserDto } from '../src/api-v1/user/dto/create-user.dto';
import { UserResponseDto } from '../src/api-v1/user/response-dto/user-response.dto';
import { DataSource } from 'typeorm';
function _createUser(userService: UserService, data: CreateUserDto | CreateAdminDto) {
return userService.createUser(data);
}
describe('User', () => {
let app: INestApplication;
let database: DataSource;
afterAll(async () => {
await clearDb(database);
await app.close();
});
describe('without auth', () => {
beforeAll(async () => {
const moduleFixture: TestingModule = await Test.createTestingModule({
imports: [UserModule, ImmichJwtModule, TypeOrmModule.forRoot(databaseConfig)],
}).compile();
app = moduleFixture.createNestApplication();
database = app.get(DataSource);
await app.init();
});
afterAll(async () => {
await app.close();
});
it('prevents fetching users if not auth', async () => {
const { status } = await request(app.getHttpServer()).get('/user');
expect(status).toEqual(401);
});
});
describe('with auth', () => {
let userService: UserService;
let authUser: UserResponseDto;
beforeAll(async () => {
const builder = Test.createTestingModule({
imports: [UserModule, TypeOrmModule.forRoot(databaseConfig)],
});
const moduleFixture: TestingModule = await authCustom(builder, () => authUser).compile();
app = moduleFixture.createNestApplication();
userService = app.get(UserService);
database = app.get(DataSource);
await app.init();
});
describe('with users in DB', () => {
const authUserEmail = 'auth-user@test.com';
const userOneEmail = 'one@test.com';
const userTwoEmail = 'two@test.com';
beforeAll(async () => {
// first user must be admin
authUser = await _createUser(userService, {
firstName: 'auth-user',
lastName: 'test',
email: authUserEmail,
password: '1234',
isAdmin: true,
});
await Promise.allSettled([
_createUser(userService, {
firstName: 'one',
lastName: 'test',
email: userOneEmail,
password: '1234',
}),
_createUser(userService, {
firstName: 'two',
lastName: 'test',
email: userTwoEmail,
password: '1234',
}),
]);
});
it('fetches the user collection excluding the auth user', async () => {
const { status, body } = await request(app.getHttpServer()).get('/user?isAll=false');
expect(status).toEqual(200);
expect(body).toHaveLength(2);
expect(body).toEqual(
expect.arrayContaining([
{
email: userOneEmail,
firstName: 'one',
lastName: 'test',
id: expect.anything(),
createdAt: expect.anything(),
isAdmin: false,
shouldChangePassword: true,
profileImagePath: '',
deletedAt: null,
},
{
email: userTwoEmail,
firstName: 'two',
lastName: 'test',
id: expect.anything(),
createdAt: expect.anything(),
isAdmin: false,
shouldChangePassword: true,
profileImagePath: '',
deletedAt: null,
},
]),
);
expect(body).toEqual(expect.not.arrayContaining([expect.objectContaining({ email: authUserEmail })]));
});
});
});
});