forked from Cutlery/immich
		
	* feat: asset e2e with job option * feat: checkout test assets * feat: library e2e tests * fix: use node 21 in e2e * fix: tests * fix: use normalized external path * feat: more external path tests * chore: use parametrized tests * chore: remove unused test code * chore: refactor test asset path * feat: centralize test app creation * fix: correct error message for missing assets * feat: test file formats * fix: don't compare checksum * feat: build libvips * fix: install meson * fix: use immich test asset repo * feat: test nikon raw files * fix: set Z timezone * feat: test offline library files * feat: richer metadata tests * feat: e2e tests in docker * feat: e2e test with arm64 docker * fix: manual docker compose run * fix: remove metadata processor import * fix: run e2e tests in test.yml * fix: checkout e2e assets * fix: typo * fix: checkout files in app directory * fix: increase e2e memory * fix: rm submodules * fix: revert action name * test: mark file offline when external path changes * feat: rename env var to TEST_ENV * docs: new test procedures * feat: can run docker e2e tests manually if needed * chore: use new node 20.8 for e2e * chore: bump exiftool-vendored * feat: simplify test launching * fix: rename env vars to use immich_ prefix * feat: asset folder is submodule * chore: cleanup after 20.8 upgrade * fix: don't log postgres in e2e * fix: better warning about not running all tests --------- Co-authored-by: Jonathan Jogenfors <jonathan@jogenfors.se>
		
			
				
	
	
		
			341 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
			
		
		
	
	
			341 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
| import { LoginResponseDto, UserResponseDto, UserService } from '@app/domain';
 | |
| import { AppModule, UserController } from '@app/immich';
 | |
| import { UserEntity } from '@app/infra/entities';
 | |
| import { INestApplication } from '@nestjs/common';
 | |
| import { api } from '@test/api';
 | |
| import { db } from '@test/db';
 | |
| import { errorStub, userSignupStub, userStub } from '@test/fixtures';
 | |
| import { createTestApp } from '@test/test-utils';
 | |
| import request from 'supertest';
 | |
| import { Repository } from 'typeorm';
 | |
| 
 | |
| describe(`${UserController.name}`, () => {
 | |
|   let app: INestApplication;
 | |
|   let server: any;
 | |
|   let loginResponse: LoginResponseDto;
 | |
|   let accessToken: string;
 | |
|   let userService: UserService;
 | |
|   let userRepository: Repository<UserEntity>;
 | |
| 
 | |
|   beforeAll(async () => {
 | |
|     app = await createTestApp();
 | |
|     userRepository = app.select(AppModule).get('UserEntityRepository');
 | |
| 
 | |
|     server = app.getHttpServer();
 | |
|   });
 | |
| 
 | |
|   beforeEach(async () => {
 | |
|     await db.reset();
 | |
|     await api.authApi.adminSignUp(server);
 | |
|     loginResponse = await api.authApi.adminLogin(server);
 | |
|     accessToken = loginResponse.accessToken;
 | |
| 
 | |
|     userService = app.get<UserService>(UserService);
 | |
|   });
 | |
| 
 | |
|   afterAll(async () => {
 | |
|     await db.disconnect();
 | |
|     await app.close();
 | |
|   });
 | |
| 
 | |
|   describe('GET /user', () => {
 | |
|     it('should require authentication', async () => {
 | |
|       const { status, body } = await request(server).get('/user');
 | |
|       expect(status).toBe(401);
 | |
|       expect(body).toEqual(errorStub.unauthorized);
 | |
|     });
 | |
| 
 | |
|     it('should start with the admin', async () => {
 | |
|       const { status, body } = await request(server).get('/user').set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toEqual(200);
 | |
|       expect(body).toHaveLength(1);
 | |
|       expect(body[0]).toMatchObject({ email: 'admin@immich.app' });
 | |
|     });
 | |
| 
 | |
|     it('should hide deleted users', async () => {
 | |
|       const user1 = await api.userApi.create(server, accessToken, {
 | |
|         email: `user1@immich.app`,
 | |
|         password: 'Password123',
 | |
|         firstName: `User 1`,
 | |
|         lastName: 'Test',
 | |
|       });
 | |
| 
 | |
|       await api.userApi.delete(server, accessToken, user1.id);
 | |
| 
 | |
|       const { status, body } = await request(server)
 | |
|         .get(`/user`)
 | |
|         .query({ isAll: true })
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toHaveLength(1);
 | |
|       expect(body[0]).toMatchObject({ email: 'admin@immich.app' });
 | |
|     });
 | |
| 
 | |
|     it('should include deleted users', async () => {
 | |
|       const user1 = await api.userApi.create(server, accessToken, {
 | |
|         email: `user1@immich.app`,
 | |
|         password: 'Password123',
 | |
|         firstName: `User 1`,
 | |
|         lastName: 'Test',
 | |
|       });
 | |
| 
 | |
|       await api.userApi.delete(server, accessToken, user1.id);
 | |
| 
 | |
|       const { status, body } = await request(server)
 | |
|         .get(`/user`)
 | |
|         .query({ isAll: false })
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toHaveLength(2);
 | |
|       expect(body[0]).toMatchObject({ id: user1.id, email: 'user1@immich.app', deletedAt: expect.any(String) });
 | |
|       expect(body[1]).toMatchObject({ id: loginResponse.userId, email: 'admin@immich.app' });
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('GET /user/info/:id', () => {
 | |
|     it('should require authentication', async () => {
 | |
|       const { status } = await request(server).get(`/user/info/${loginResponse.userId}`);
 | |
|       expect(status).toEqual(401);
 | |
|     });
 | |
| 
 | |
|     it('should get the user info', async () => {
 | |
|       const { status, body } = await request(server)
 | |
|         .get(`/user/info/${loginResponse.userId}`)
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toMatchObject({ id: loginResponse.userId, email: 'admin@immich.app' });
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('GET /user/me', () => {
 | |
|     it('should require authentication', async () => {
 | |
|       const { status, body } = await request(server).get(`/user/me`);
 | |
|       expect(status).toBe(401);
 | |
|       expect(body).toEqual(errorStub.unauthorized);
 | |
|     });
 | |
| 
 | |
|     it('should get my info', async () => {
 | |
|       const { status, body } = await request(server).get(`/user/me`).set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toMatchObject({ id: loginResponse.userId, email: 'admin@immich.app' });
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('POST /user', () => {
 | |
|     it('should require authentication', async () => {
 | |
|       const { status, body } = await request(server).post(`/user`).send(userSignupStub);
 | |
|       expect(status).toBe(401);
 | |
|       expect(body).toEqual(errorStub.unauthorized);
 | |
|     });
 | |
| 
 | |
|     for (const key of Object.keys(userSignupStub)) {
 | |
|       it(`should not allow null ${key}`, async () => {
 | |
|         const { status, body } = await request(server)
 | |
|           .post(`/user`)
 | |
|           .set('Authorization', `Bearer ${accessToken}`)
 | |
|           .send({ ...userSignupStub, [key]: null });
 | |
|         expect(status).toBe(400);
 | |
|         expect(body).toEqual(errorStub.badRequest());
 | |
|       });
 | |
|     }
 | |
| 
 | |
|     it('should ignore `isAdmin`', async () => {
 | |
|       const { status, body } = await request(server)
 | |
|         .post(`/user`)
 | |
|         .send({
 | |
|           isAdmin: true,
 | |
|           email: 'user1@immich.app',
 | |
|           password: 'Password123',
 | |
|           firstName: 'Immich',
 | |
|           lastName: 'User',
 | |
|         })
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(body).toMatchObject({
 | |
|         email: 'user1@immich.app',
 | |
|         isAdmin: false,
 | |
|         shouldChangePassword: true,
 | |
|       });
 | |
|       expect(status).toBe(201);
 | |
|     });
 | |
| 
 | |
|     it('should create a user without memories enabled', async () => {
 | |
|       const { status, body } = await request(server)
 | |
|         .post(`/user`)
 | |
|         .send({
 | |
|           email: 'no-memories@immich.app',
 | |
|           password: 'Password123',
 | |
|           firstName: 'No Memories',
 | |
|           lastName: 'User',
 | |
|           memoriesEnabled: false,
 | |
|         })
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(body).toMatchObject({
 | |
|         email: 'no-memories@immich.app',
 | |
|         memoriesEnabled: false,
 | |
|       });
 | |
|       expect(status).toBe(201);
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('DELETE /user/:id', () => {
 | |
|     let userToDelete: UserResponseDto;
 | |
| 
 | |
|     beforeEach(async () => {
 | |
|       userToDelete = await api.userApi.create(server, accessToken, {
 | |
|         email: userStub.user1.email,
 | |
|         firstName: userStub.user1.firstName,
 | |
|         lastName: userStub.user1.lastName,
 | |
|         password: 'superSecurePassword',
 | |
|       });
 | |
|     });
 | |
| 
 | |
|     it('should require authentication', async () => {
 | |
|       const { status, body } = await request(server).delete(`/user/${userToDelete.id}`);
 | |
|       expect(status).toBe(401);
 | |
|       expect(body).toEqual(errorStub.unauthorized);
 | |
|     });
 | |
| 
 | |
|     it('should delete user', async () => {
 | |
|       const deleteRequest = await request(server)
 | |
|         .delete(`/user/${userToDelete.id}`)
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
| 
 | |
|       expect(deleteRequest.status).toBe(200);
 | |
|       expect(deleteRequest.body).toEqual({
 | |
|         ...userToDelete,
 | |
|         updatedAt: expect.any(String),
 | |
|         deletedAt: expect.any(String),
 | |
|       });
 | |
| 
 | |
|       await userRepository.save({ id: deleteRequest.body.id, deletedAt: new Date('1970-01-01').toISOString() });
 | |
| 
 | |
|       await userService.handleUserDelete({ id: userToDelete.id });
 | |
| 
 | |
|       const { status, body } = await request(server)
 | |
|         .get('/user')
 | |
|         .query({ isAll: false })
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
| 
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toHaveLength(1);
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('PUT /user', () => {
 | |
|     it('should require authentication', async () => {
 | |
|       const { status, body } = await request(server).put(`/user`);
 | |
|       expect(status).toBe(401);
 | |
|       expect(body).toEqual(errorStub.unauthorized);
 | |
|     });
 | |
| 
 | |
|     for (const key of Object.keys(userStub.admin)) {
 | |
|       it(`should not allow null ${key}`, async () => {
 | |
|         const { status, body } = await request(server)
 | |
|           .put(`/user`)
 | |
|           .set('Authorization', `Bearer ${accessToken}`)
 | |
|           .send({ ...userStub.admin, [key]: null });
 | |
|         expect(status).toBe(400);
 | |
|         expect(body).toEqual(errorStub.badRequest());
 | |
|       });
 | |
|     }
 | |
| 
 | |
|     it('should not allow a non-admin to become an admin', async () => {
 | |
|       const user = await api.userApi.create(server, accessToken, {
 | |
|         email: 'user1@immich.app',
 | |
|         password: 'Password123',
 | |
|         firstName: 'Immich',
 | |
|         lastName: 'User',
 | |
|       });
 | |
| 
 | |
|       const { status, body } = await request(server)
 | |
|         .put(`/user`)
 | |
|         .send({ isAdmin: true, id: user.id })
 | |
|         .set('Authorization', `Bearer ${accessToken}`);
 | |
| 
 | |
|       expect(status).toBe(400);
 | |
|       expect(body).toEqual(errorStub.alreadyHasAdmin);
 | |
|     });
 | |
| 
 | |
|     it('ignores updates to profileImagePath', async () => {
 | |
|       const user = await api.userApi.update(server, accessToken, {
 | |
|         id: loginResponse.userId,
 | |
|         profileImagePath: 'invalid.jpg',
 | |
|       } as any);
 | |
| 
 | |
|       expect(user).toMatchObject({ id: loginResponse.userId, profileImagePath: '' });
 | |
|     });
 | |
| 
 | |
|     it('should ignore updates to createdAt, updatedAt and deletedAt', async () => {
 | |
|       const before = await api.userApi.get(server, accessToken, loginResponse.userId);
 | |
|       const after = await api.userApi.update(server, accessToken, {
 | |
|         id: loginResponse.userId,
 | |
|         createdAt: '2023-01-01T00:00:00.000Z',
 | |
|         updatedAt: '2023-01-01T00:00:00.000Z',
 | |
|         deletedAt: '2023-01-01T00:00:00.000Z',
 | |
|       } as any);
 | |
| 
 | |
|       expect(after).toStrictEqual(before);
 | |
|     });
 | |
| 
 | |
|     it('should update first and last name', async () => {
 | |
|       const before = await api.userApi.get(server, accessToken, loginResponse.userId);
 | |
|       const after = await api.userApi.update(server, accessToken, {
 | |
|         id: before.id,
 | |
|         firstName: 'First Name',
 | |
|         lastName: 'Last Name',
 | |
|       });
 | |
| 
 | |
|       expect(after).toEqual({
 | |
|         ...before,
 | |
|         updatedAt: expect.any(String),
 | |
|         firstName: 'First Name',
 | |
|         lastName: 'Last Name',
 | |
|       });
 | |
|       expect(before.updatedAt).not.toEqual(after.updatedAt);
 | |
|     });
 | |
| 
 | |
|     it('should update memories enabled', async () => {
 | |
|       const before = await api.userApi.get(server, accessToken, loginResponse.userId);
 | |
|       const after = await api.userApi.update(server, accessToken, {
 | |
|         id: before.id,
 | |
|         memoriesEnabled: false,
 | |
|       });
 | |
| 
 | |
|       expect(after).toMatchObject({
 | |
|         ...before,
 | |
|         updatedAt: expect.anything(),
 | |
|         memoriesEnabled: false,
 | |
|       });
 | |
|       expect(before.updatedAt).not.toEqual(after.updatedAt);
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('GET /user/count', () => {
 | |
|     it('should not require authentication', async () => {
 | |
|       const { status, body } = await request(server).get(`/user/count`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toEqual({ userCount: 1 });
 | |
|     });
 | |
| 
 | |
|     it('should start with just the admin', async () => {
 | |
|       const { status, body } = await request(server).get(`/user/count`).set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toEqual({ userCount: 1 });
 | |
|     });
 | |
| 
 | |
|     it('should return the total user count', async () => {
 | |
|       for (let i = 0; i < 5; i++) {
 | |
|         await api.userApi.create(server, accessToken, {
 | |
|           email: `user${i + 1}@immich.app`,
 | |
|           password: 'Password123',
 | |
|           firstName: `User ${i + 1}`,
 | |
|           lastName: 'Test',
 | |
|         });
 | |
|       }
 | |
|       const { status, body } = await request(server).get(`/user/count`).set('Authorization', `Bearer ${accessToken}`);
 | |
|       expect(status).toBe(200);
 | |
|       expect(body).toEqual({ userCount: 6 });
 | |
|     });
 | |
|   });
 | |
| });
 |