tbelway/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-07-09 03:06:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

add todos

Browse Source
This commit is contained in:
tiefseetauchner 2024-08-15 20:25:30 +02:00
parent 5c9ef5c6fd
commit 8e130a6e3e
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cli/src/commands/asset.spec.ts
View File

@ -190,6 +190,8 @@ describe('checkForDuplicates', () => {
}); });
}); });
// TODO: this shouldn't return empty arrays, this should return an error
// Failed duplicate checks should be a reason for panic instead of ignoring
it('returns results when check duplicates retry is failed', async () => { it('returns results when check duplicates retry is failed', async () => {
vi.mocked(checkBulkUpload).mockRejectedValue(new Error('Network error')); vi.mocked(checkBulkUpload).mockRejectedValue(new Error('Network error'));

6
cli/src/commands/asset.ts
View File

@ -122,7 +122,10 @@ export const checkForDuplicates = async (files: string[], { concurrency, skipHas
const newFiles: string[] = []; const newFiles: string[] = [];
const duplicates: Asset[] = []; const duplicates: Asset[] = [];
// TODO: Retry 3 times if there is an error
try {
const response = await checkBulkUpload({ assetBulkUploadCheckDto: { assets: results } }); const response = await checkBulkUpload({ assetBulkUploadCheckDto: { assets: results } });
for (const { id: filepath, assetId, action } of response.results) { for (const { id: filepath, assetId, action } of response.results) {
if (action === Action.Accept) { if (action === Action.Accept) {
newFiles.push(filepath); newFiles.push(filepath);
@ -131,6 +134,9 @@ export const checkForDuplicates = async (files: string[], { concurrency, skipHas
duplicates.push({ id: assetId as string, filepath }); duplicates.push({ id: assetId as string, filepath });
} }
} }
} catch (error: any) {
throw new Error(`An error occurred while checking for duplicates: ${error.message}`);
}
progressBar.stop(); progressBar.stop();