From f4e016edb5b5c15c2e99a6c0afbb1a9159bc7e51 Mon Sep 17 00:00:00 2001
From: bo0tzz <git@bo0tzz.me>
Date: Sat, 18 Apr 2026 15:25:22 +0200
Subject: [PATCH] chore: move clearCookie to finally

---
 server/src/controllers/oauth.controller.ts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/server/src/controllers/oauth.controller.ts b/server/src/controllers/oauth.controller.ts
index 0d9e737ff0..a961e6c02c 100644
--- a/server/src/controllers/oauth.controller.ts
+++ b/server/src/controllers/oauth.controller.ts
@@ -75,8 +75,6 @@ export class OAuthController {
   ): Promise<LoginResponseDto> {
     try {
       const body = await this.service.callback(dto, request.headers, loginDetails);
-      res.clearCookie(ImmichCookie.OAuthState);
-      res.clearCookie(ImmichCookie.OAuthCodeVerifier);
       return respondWithCookie(res, body, {
         isSecure: loginDetails.isSecure,
         values: [
@@ -87,14 +85,15 @@ export class OAuthController {
       });
     } catch (error) {
       if (error instanceof OAuthLinkRequiredException) {
-        res.clearCookie(ImmichCookie.OAuthState);
-        res.clearCookie(ImmichCookie.OAuthCodeVerifier);
         respondWithCookie(res, null, {
           isSecure: loginDetails.isSecure,
           values: [{ key: ImmichCookie.OAuthLinkToken, value: error.oauthLinkToken }],
         });
       }
       throw error;
+    } finally {
+      res.clearCookie(ImmichCookie.OAuthState);
+      res.clearCookie(ImmichCookie.OAuthCodeVerifier);
     }
   }