Removed a hack that was put in when users complained about a tool improperly tagging. This is not the case for most tools. (#949)

This commit is contained in:
Joseph Milazzo 2022-01-16 15:46:41 -08:00 committed by GitHub
parent e9325824a3
commit 2434e96fe9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 16 deletions

View File

@ -30,13 +30,6 @@ namespace API.Tests.Services
_archiveService = new ArchiveService(_logger, _directoryService, new ImageService(Substitute.For<ILogger<ImageService>>(), _directoryService)); _archiveService = new ArchiveService(_logger, _directoryService, new ImageService(Substitute.For<ILogger<ImageService>>(), _directoryService));
} }
// [Fact]
// public void CleanComicInfo_ShouldMapVolumeAndChapterNormally()
// {
// // TODO: Implement this
// Assert.False(true);
// }
[Theory] [Theory]
[InlineData("flat file.zip", false)] [InlineData("flat file.zip", false)]
[InlineData("file in folder in folder.zip", true)] [InlineData("file in folder in folder.zip", true)]

View File

@ -322,15 +322,15 @@ namespace API.Services
info.Publisher = Parser.Parser.CleanAuthor(info.Publisher); info.Publisher = Parser.Parser.CleanAuthor(info.Publisher);
info.Characters = Parser.Parser.CleanAuthor(info.Characters); info.Characters = Parser.Parser.CleanAuthor(info.Characters);
if (!string.IsNullOrEmpty(info.Web)) // if (!string.IsNullOrEmpty(info.Web))
{ // {
// ComicVine stores the Issue number in Number field and does not use Volume. // // ComicVine stores the Issue number in Number field and does not use Volume.
if (!info.Web.Contains("https://comicvine.gamespot.com/")) return; // if (!info.Web.Contains("https://comicvine.gamespot.com/")) return;
if (info.Volume.Equals("1")) // if (info.Volume.Equals("1"))
{ // {
info.Volume = Parser.Parser.DefaultVolume; // info.Volume = Parser.Parser.DefaultVolume;
} // }
} // }
} }
/// <summary> /// <summary>