Cleanly handle unsupported subtitles (#944)

front/packages/ui/src/player/components/right-buttons.tsx

@@ -71,7 +71,9 @@ export const RightButtons = ({
 						selected={!selectedSubtitle}
 						onSelect={() => setSubtitle(null)}
 					/>
-					{subtitles.map((x, i) => (
+					{subtitles
+						.filter((x) => !!x.link)
+						.map((x, i) => (
 							<Menu.Item
 								key={x.index ?? i}
 								label={x.link ? getSubtitleName(x) : `${getSubtitleName(x)} (${x.codec})`}

front/packages/ui/src/player/video.tsx

@@ -109,7 +109,9 @@ const Video = forwardRef<VideoRef, VideoProps>(function Video(
 				}
 				// when video file is invalid, audio is undefined
 				selectedAudioTrack={{ type: SelectedTrackType.INDEX, value: audio?.index ?? 0 }}
-				textTracks={subtitles?.map((x) => ({
+				textTracks={subtitles
+					?.filter((x) => !!x.link)
+					.map((x) => ({
 						type: MimeTypes.get(x.codec) as any,
 						uri: x.link!,
 						title: x.title ?? "Unknown",

transcoder/src/extract.go

@@ -63,8 +63,15 @@ func (s *MetadataService) GetSubtitle(ctx context.Context, sha string, name stri
 func (s *MetadataService) extractSubs(ctx context.Context, info *MediaInfo) (err error) {
 	defer utils.PrintExecTime("extraction of %s", info.Path)()
 
-	// If there is no subtitles, there is nothing to extract (also fonts would be useless).
-	if len(info.Subtitles) == 0 {
+	// If there are no supported, embedded subtitles, there is nothing to extract.
+	hasSupportedSubtitle := false
+	for _, sub := range info.Subtitles {
+		if !sub.IsExternal && sub.Extension != nil {
+			hasSupportedSubtitle = true
+			break
+		}
+	}
+	if !hasSupportedSubtitle {
 		return nil
 	}