Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

More useful error message when fetching plugins list fails

Browse Source
This commit is contained in:
Kovid Goyal 2016-03-22 20:45:10 +05:30
parent cae761166f
commit 059f3f70c0
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/calibre/gui2/dialogs/plugin_updater.py
View File

@ -430,7 +430,14 @@ class PluginUpdaterDialog(SizePersistedDialog):
self._initialize_controls() self._initialize_controls()
self._create_context_menu() self._create_context_menu()
display_plugins = read_available_plugins() try:
display_plugins = read_available_plugins(raise_error=True)
except Exception:
display_plugins = []
import traceback
error_dialog(self.gui, _('Update Check Failed'),
_('Unable to reach the plugin index page.'),
det_msg=traceback.format_exc(), show=True)
if display_plugins: if display_plugins:
self.model = DisplayPluginModel(display_plugins) self.model = DisplayPluginModel(display_plugins)
@ -443,9 +450,6 @@ class PluginUpdaterDialog(SizePersistedDialog):
self.filter_combo.setCurrentIndex(initial_filter) self.filter_combo.setCurrentIndex(initial_filter)
self._select_and_focus_view() self._select_and_focus_view()
else: else:
error_dialog(self.gui, _('Update Check Failed'),
_('Unable to reach the plugin index page.'),
det_msg=INDEX_URL, show=True)
self.filter_combo.setEnabled(False) self.filter_combo.setEnabled(False)
# Cause our dialog size to be restored from prefs or created on first usage # Cause our dialog size to be restored from prefs or created on first usage
self.resize_dialog() self.resize_dialog()