list comprehension is faster than the function call overhead of list()

This commit is contained in:
Eli Schwartz 2019-09-09 17:44:04 -04:00
parent 9320e2fe22
commit 1c5ea10a34
No known key found for this signature in database
GPG Key ID: CEB167EFB5722BD6

View File

@ -3526,9 +3526,9 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns):
for book_id, fmt in postimport:
run_plugins_on_postimport(self, book_id, fmt)
if duplicates:
paths = list(duplicate[0] for duplicate in duplicates)
formats = list(duplicate[1] for duplicate in duplicates)
metadata = list(duplicate[2] for duplicate in duplicates)
paths = [duplicate[0] for duplicate in duplicates]
formats = [duplicate[1] for duplicate in duplicates]
metadata = [duplicate[2] for duplicate in duplicates]
return (paths, formats, metadata), (ids if return_ids else
len(ids))
return None, (ids if return_ids else len(ids))