Commit Graph

41006 Commits

Author SHA1 Message Date
Kovid Goyal cbbcec8525 Clicking selection bar buttons should not steal focus from iframe 2020-08-22 18:48:23 +05:30
Kovid Goyal cbdaad0003 Allow configuring the search URL 2020-08-22 18:48:23 +05:30
Kovid Goyal 83d5865d4c Show the highlight and lookup actions if the selection bar is disabled 2020-08-22 18:48:23 +05:30
Kovid Goyal dd3dad6cb6 Revert "Remove lookup and highlight actions from chrome"
This reverts commit c7d9ae13e2.
2020-08-22 18:48:22 +05:30
Kovid Goyal 20b76a0ae7 Add a preference to turn off the selection popup bar 2020-08-22 18:48:22 +05:30
Kovid Goyal 0848740051 misc cleanups for RTL merge 2020-08-22 18:48:22 +05:30
Kovid Goyal a681d71608 Document that currently flow mode does not care about RTL/LTR 2020-08-22 18:48:22 +05:30
Kovid Goyal 769ca0c59f Avoid multiple calls to getComputedStyle() 2020-08-22 18:48:22 +05:30
Kovid Goyal b0e1506976 ltr and rtl should both be properties
Otherwise its easy to forget which is which
2020-08-22 18:48:22 +05:30
Kovid Goyal 1001f254a3 Only set transform is needed
Probably browsers dont do anything if the value doesn't change anyway,
but I'd rather not rely on that
2020-08-22 18:48:22 +05:30
Mark W. Gabby-Li d9a343dad6 Support for Books in RTL Languages, Such as Hebrew
Three parts: RTL layout support, made inputs behave naturally in RTL modes, and updated tutorial for RTL books.

To add RTL layout support:
 ‣ Don't force LTR layout on DOM when loading.
 ‣ Disable "overflow: hidden" in RTL mode to compensate for an issue in Chrome, and disable scrollbars on all browsers to compensate for the side effect of this turning on scrollbars.
 ‣ Have viewport hide the RTL mode by negating scrolls and viewport position requests in RTL mode.
 ‣ Initialize viewport in paged mode layout so that it properly saves RTL mode.
 ‣ Remove all raw calls to pageXOffset and pageYOffset
 ‣ Put viewport_to_document in ScrollViewport so that it can abstract away RTL mode in this case, too.
   ‣ Get rid of calls to reset_transforms and make it private, since it is only called to prepare for viewport_to_document. Put the call there, instead.
 ‣ Use bounding box right instead of left for position of various elements when the viewport is in RTL mode, since the right side is the beginning of the element in this case.

To made input behave naturally in RTL:
 ‣ Get page progression direction from ePub.
 ‣ Add rtl_page_progression() function to return whether we're in this mode.
 ‣ Added support to tell page advance functions whether they should flip their direction if RTL is on.
 ‣ Changed touch behavior to support different position for going back and forward in RTL books.

Tutorial changes:
 ‣ Flipped tutorial so that next and previous page are reversed in position and size in RTL mode.
 ‣ Added a new counter so that RTL tutorial is shown even if user has already seen LTR tutorial.
2020-08-22 18:48:22 +05:30
Kovid Goyal 72173970da Replace use of magic constant since it is available as a named constant in py3 2020-08-22 18:48:22 +05:30
Kovid Goyal d8979c20cb The copy button in the selection bar should work in the browser viewer as well 2020-08-22 18:48:22 +05:30
Kovid Goyal 593d652150 Fix restrictions dropdown not being initialized when using annots browser from within main GUI 2020-08-22 18:48:21 +05:30
Kovid Goyal 2316f291e0 Fix combination of type and user restriction not working 2020-08-22 18:48:21 +05:30
Kovid Goyal 01f14b8928 Bump beta version 2020-08-22 18:48:21 +05:30
Kovid Goyal d90e866e9b Limit the amount of highlighted text displayed in the highlights panel 2020-08-22 18:48:21 +05:30
Kovid Goyal 1fcd002121 Adjust documentation for new selection bar 2020-08-22 18:48:21 +05:30
Kovid Goyal 7bac3a8737 Button to export highlights from viewer 2020-08-22 18:48:21 +05:30
Kovid Goyal 0bdde24493 SOme keyboard controls for the highlights list 2020-08-22 18:48:21 +05:30
Kovid Goyal 12d1b31e98 Partition create_annotations.pyj 2020-08-22 18:48:21 +05:30
Kovid Goyal 8cbb068b04 Fix multi-wrap when editing existing highlight 2020-08-22 18:48:21 +05:30
Kovid Goyal c99f18eb62 ... 2020-08-22 18:48:20 +05:30
Kovid Goyal 87ca655075 Fix annots disappearing on settings change 2020-08-22 18:48:20 +05:30
Kovid Goyal d053dc26ea Allow custom colors for highlights 2020-08-22 18:48:20 +05:30
Kovid Goyal 709a9658a9 Clear selection after removing highlight 2020-08-22 18:48:20 +05:30
Kovid Goyal a6dd65bea4 Add a button to selection bar to search net 2020-08-22 18:48:20 +05:30
Kovid Goyal de76fbbda2 Lookup word should work on content server as well 2020-08-22 18:48:20 +05:30
Kovid Goyal 7d00a8cf12 Remove lookup and highlight actions from chrome
They are better accessed via the selection bar
2020-08-22 18:48:20 +05:30
Kovid Goyal 94c28fc92d ... 2020-08-22 18:48:20 +05:30
Kovid Goyal fd08608ba5 Simplify hiding handles 2020-08-22 18:48:20 +05:30
Kovid Goyal a992d0a976 Hide buttons when showing middle 2020-08-22 18:48:20 +05:30
Kovid Goyal 8aad5bd72f Better calculation of selection extents 2020-08-22 18:48:19 +05:30
Kovid Goyal 0407959ce4 ... 2020-08-22 18:48:19 +05:30
Kovid Goyal 8e609162c2 ... 2020-08-22 18:48:19 +05:30
Kovid Goyal 8a4cc1d7ba position selection bar at mouse x during drag 2020-08-22 18:48:19 +05:30
Kovid Goyal 6f919231f1 Misc selection bar work
Use an object for tracking selections
Track mouse position while selecting
Remove copy selection action from chrome
2020-08-22 18:48:19 +05:30
Kovid Goyal 2078309b52 Show highlight notes in the select bar 2020-08-22 18:48:19 +05:30
Kovid Goyal 6436d36f2e Make the QT_VERSION available to the JS runtime 2020-08-22 18:48:19 +05:30
Kovid Goyal d2db909851 Dont use zero offset for element selections 2020-08-22 18:48:19 +05:30
Kovid Goyal 366a69a3cd Fix decoding of CFI in a tag that has a range wrapper as its first child 2020-08-22 18:48:19 +05:30
Kovid Goyal 0c233efa27 Expicitly mark is selection extent was found or not 2020-08-22 18:48:18 +05:30
Kovid Goyal 9f4609aec2 Ensure pre-middle-close-callback is called only once if it returns True 2020-08-22 18:48:18 +05:30
Kovid Goyal a3bc2c9d56 Fix selection extents not being reported correctly when selection ends at an element node 2020-08-22 18:48:18 +05:30
Kovid Goyal f037fe8dbe Misc fixes for editing highlights 2020-08-22 18:48:18 +05:30
Kovid Goyal 4c05616e7d Buttons to finish editing highlight 2020-08-22 18:48:18 +05:30
Kovid Goyal 74cb446c60 Ensure handle colors are set properly 2020-08-22 18:48:18 +05:30
Kovid Goyal 3a5d99051c Prevent selection_bar from becoming visible when create annotations panel is visible 2020-08-22 18:48:18 +05:30
Kovid Goyal fcbdfc570d Work on using a single panel to edit both notes and colors at once 2020-08-22 18:48:18 +05:30
Kovid Goyal 106c84e8b7 Add a highlight button to the selection bar 2020-08-22 18:48:18 +05:30