fix: verify form disposal before notifyListeners

2026-05-23 16:12:30 -04:00 · 2026-05-23 23:59:19 +05:30
1 changed files with 11 additions and 8 deletions
@@ -10,9 +10,16 @@ class ImmichFormController extends ChangeNotifier {
  FutureOr<void> Function()? onSubmit;
  final formKey = GlobalKey<FormState>();

+  bool _isDisposed = false;
  bool _isLoading = false;
  bool get isLoading => _isLoading;

+  @override
+  void dispose() {
+    _isDisposed = true;
+    super.dispose();
+  }
+
  Future<void> submit() async {
    if (_isLoading) {
      return;
@@ -27,7 +34,9 @@ class ImmichFormController extends ChangeNotifier {
      await onSubmit?.call();
    } finally {
      _isLoading = false;
-      notifyListeners();
+      if (!_isDisposed) {
+        notifyListeners();
+      }
    }
  }
 }
@@ -38,13 +47,7 @@ class ImmichForm extends StatefulWidget {
  final String? submitText;
  final IconData? submitIcon;

-  const ImmichForm({
-    super.key,
-    this.onSubmit,
-    this.submitText,
-    this.submitIcon,
-    required this.builder,
-  });
+  const ImmichForm({super.key, this.onSubmit, this.submitText, this.submitIcon, required this.builder});

  @override
  State<ImmichForm> createState() => _ImmichFormState();